gh-74772: Adds signature checking for mock autospec object method calls#122128
Open
claudiubelu wants to merge 1 commit intopython:mainfrom
Open
gh-74772: Adds signature checking for mock autospec object method calls#122128claudiubelu wants to merge 1 commit intopython:mainfrom
claudiubelu wants to merge 1 commit intopython:mainfrom
Conversation
claudiubelu
force-pushed
the
mock-add-autospec
branch
from
9cd3f9b to
910831e
Compare
Author
|
Original PR: #1982 Rebased. Addressed comments in the original PR. |
Mock can accept an spec object / class as argument, making sure
that accessing attributes that do not exist in the spec will cause an
AttributeError to be raised, but there is no guarantee that the spec's
methods signatures are respected in any way. This creates the possibility
to have faulty code with passing unittests and assertions.
Example:
from unittest import mock
class Something(object):
def foo(self, a, b, c, d):
pass
m = mock.Mock(spec=Something)
m.foo()
Adds the autospec argument to Mock, and its mock_add_spec method.
Passes the spec's attribute with the same name to the child mock (spec-ing
the child), if the mock's autospec is True.
Sets _mock_check_sig if the given spec is callable.
Adds unit tests to validate the fact that the autospec method signatures are
respected.
claudiubelu
force-pushed
the
mock-add-autospec
branch
from
910831e to
7eca2ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock can accept an spec object / class as argument, making sure that accessing attributes that do not exist in the spec will cause an AttributeError to be raised, but there is no guarantee that the spec's methods signatures are respected in any way. This creates the possibility to have faulty code with passing unittests and assertions.
Example:
Adds the autospec argument to Mock, and its mock_add_spec method.
Passes the spec's attribute with the same name to the child mock (spec-ing the child), if the mock's autospec is True.
Sets
_mock_check_sigif the given spec is callable.Adds unit tests to validate the fact that the autospec method signatures are respected.