Skip to content

gh-121988: Fix test hang when pyrepl is not available#121990

Merged
pablogsal merged 2 commits into
python:mainfrom
colesbury:gh-121988-repl-exit
Jul 20, 2024
Merged

gh-121988: Fix test hang when pyrepl is not available#121990
pablogsal merged 2 commits into
python:mainfrom
colesbury:gh-121988-repl-exit

Conversation

@colesbury

@colesbury colesbury commented Jul 18, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Also explicitly fail the test if we timeout while waiting for output so that this failure mode is caught earlier.

@colesbury
pythongh-121988: Fix test hang when pyrepl is not available
d8b1726 
Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 18, 2024
@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 18, 2024
@bedevere-bot

bedevere-bot commented Jul 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit d8b1726 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 18, 2024
@colesbury colesbury added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jul 18, 2024
@bedevere-bot

bedevere-bot commented Jul 18, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit d8b1726 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 18, 2024
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
@colesbury

colesbury commented Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

test_cprofile is failing in main for unrelated reasons. It looks like this fixes the test hang:

https://buildbot.python.org/#/builders/474/builds/1630
https://buildbot.python.org/#/builders/1287/builds/289

@colesbury
colesbury marked this pull request as ready for review July 19, 2024 01:58
@colesbury
colesbury requested a review from AlexWaygood July 19, 2024 01:58
@pablogsal
pablogsal merged commit a09e215 into python:main Jul 20, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2024
@colesbury @miss-islington
pythongh-121988: Fix test hang when pyrepl is not available (pythonGH…
671190f 
…-121990)

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@pablogsal

pablogsal commented Jul 20, 2024

Copy link
Copy Markdown
Member

Thanks for the fix @colesbury!

@bedevere-app

bedevere-app Bot commented Jul 20, 2024

Copy link
Copy Markdown

GH-122064 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 20, 2024
pablogsal pushed a commit that referenced this pull request Jul 20, 2024
@miss-islington @colesbury
[3.13] gh-121988: Fix test hang when pyrepl is not available (GH-121990…
bd5121b 
…) (#122064)

gh-121988: Fix test hang when pyrepl is not available (GH-121990)

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@colesbury
colesbury deleted the gh-121988-repl-exit branch July 22, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @bedevere-bot @pablogsal