Skip to content

bpo-36139: release GIL around munmap()#12199

Merged
vstinner merged 1 commit into
python:masterfrom
sorcio:fix-issue-36139
Mar 6, 2019
Merged

bpo-36139: release GIL around munmap()#12199
vstinner merged 1 commit into
python:masterfrom
sorcio:fix-issue-36139

Conversation

@sorcio

@sorcio sorcio commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

@sorcio sorcio changed the title release GIL around munmap() bpo-36139: release GIL around munmap() Mar 6, 2019
@vstinner

vstinner commented Mar 6, 2019

Copy link
Copy Markdown
Member

Hum, bb9593a has been merged. What is this PR?

@vstinner

vstinner commented Mar 6, 2019

Copy link
Copy Markdown
Member

It seems like this PR isn't written on top of the master branch, currently it means the commit bb9593a.

@sorcio
sorcio force-pushed the fix-issue-36139 branch from 3ee3103 to 33e10b9 Compare March 6, 2019 16:45
@sorcio

sorcio commented Mar 6, 2019

Copy link
Copy Markdown
Contributor Author

It seems like this PR isn't written on top of the master branch, currently it means the commit bb9593a.

@vstinner I rebased on master now

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

vstinner commented Mar 6, 2019

Copy link
Copy Markdown
Member

Thanks @sorcio for the quick fix!

FYI I tested manually the fix on my Windows VM with Python compiled in debug mode before merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants