Skip to content

gh-121605: Fix test hang when pyrepl is not available#121820

Merged
ambv merged 1 commit into
python:mainfrom
colesbury:gh-121605-repl-hang
Jul 15, 2024
Merged

gh-121605: Fix test hang when pyrepl is not available#121820
ambv merged 1 commit into
python:mainfrom
colesbury:gh-121605-repl-hang

Conversation

@colesbury

@colesbury colesbury commented Jul 15, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The fallback repl does not support "exit" without parentheses, so the test would hang until the timeout expired if pyrepl is not available.

@colesbury
pythongh-121605: Fix test hang when pyrepl is not available
1158009 
The fallback repl does not support "exit" without parentheses, so the
test would hang until the timeout expired.
@colesbury colesbury added tests Tests in the Lib/test dir skip news needs backport to 3.13 bugs and security fixes labels Jul 15, 2024
@colesbury
colesbury requested a review from pablogsal July 15, 2024 21:48
@bedevere-app bedevere-app Bot mentioned this pull request Jul 15, 2024
Closed
@colesbury

colesbury commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot nogil refleaks

@bedevere-bot

bedevere-bot commented Jul 15, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 1158009 🤖

The command will test the builders whose names match following regular expression: nogil refleaks

The builders matched are:

  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR

@ambv ambv added the topic-repl Related to the interactive shell label Jul 15, 2024
@ambv
ambv merged commit 4134261 into python:main Jul 15, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 15, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2024
@colesbury @miss-islington
pythongh-121605: Fix test hang when pyrepl is not available (pythonGH…
ac3fc0b 
…-121820)

The fallback repl does not support "exit" without parentheses, so the
test would hang until the timeout expired.
(cherry picked from commit 4134261)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 15, 2024

Copy link
Copy Markdown

GH-121823 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 15, 2024
@colesbury
colesbury deleted the gh-121605-repl-hang branch July 15, 2024 22:55
ambv pushed a commit that referenced this pull request Jul 15, 2024
@miss-islington @colesbury
[3.13] gh-121605: Fix test hang when pyrepl is not available (GH-121820…
0201b98 
…) (GH-121823)

The fallback repl does not support "exit" without parentheses, so the
test would hang until the timeout expired.
(cherry picked from commit 4134261)

Co-authored-by: Sam Gross <colesbury@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-121605: Fix test hang when pyrepl is not available (pythonGH…
75edf76 
…-121820)

The fallback repl does not support "exit" without parentheses, so the
test would hang until the timeout expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @bedevere-bot @ambv