Skip to content

gh-121605: Increase timeout in test_pyrepl.run_repl#121606

Merged
pablogsal merged 1 commit into
python:mainfrom
colesbury:gh-121605-run-repl-timeout
Jul 13, 2024
Merged

gh-121605: Increase timeout in test_pyrepl.run_repl#121606
pablogsal merged 1 commit into
python:mainfrom
colesbury:gh-121605-run-repl-timeout

Conversation

@colesbury

@colesbury colesbury commented Jul 10, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

We also need to close the slave_fd earlier so that reading from master_fd won't block forever when the subprocess finishes.

@colesbury
pythongh-121605: Increase timeout in test_pyrepl.run_repl
ee99425 
We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
@colesbury colesbury added skip news topic-repl Related to the interactive shell labels Jul 10, 2024
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 10, 2024
Closed
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Jul 10, 2024
@colesbury
colesbury marked this pull request as ready for review July 10, 2024 23:40
@pablogsal
pablogsal merged commit abc3aee into python:main Jul 13, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 13, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
@colesbury @miss-islington
pythongh-121605: Increase timeout in test_pyrepl.run_repl (pythonGH-1…
9f47df9 
…21606)

We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
(cherry picked from commit abc3aee)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 13, 2024

Copy link
Copy Markdown

GH-121702 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 13, 2024
IljaManakov pushed a commit to IljaManakov/cpython that referenced this pull request Jul 13, 2024
@colesbury @IljaManakov
pythongh-121605: Increase timeout in test_pyrepl.run_repl (python#121606
24b67e2 
)

We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
colesbury added a commit that referenced this pull request Jul 13, 2024
@miss-islington @colesbury
[3.13] gh-121605: Increase timeout in test_pyrepl.run_repl (GH-121606) (
14c5bff 
#121702)

We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
(cherry picked from commit abc3aee)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@colesbury
colesbury deleted the gh-121605-run-repl-timeout branch July 15, 2024 21:06
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-121605: Increase timeout in test_pyrepl.run_repl (python#121606
8c71e4b 
)

We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury @pablogsal