gh-120726: Fix warnings#120727
Merged
Merged
Conversation
Eclips4
requested review from
ericsnowcurrently and
kumaraditya303
as code owners
June 19, 2024 06:38
Contributor
|
Thanks, I had noticed this a few times already, but thought it was a macOS issue. |
Member
Author
|
|
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
vstinner
approved these changes
Jun 19, 2024
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. But next time, try to find a better PR title, since this one is very generic. I will enhance it when I will merge your PR.
Contributor
|
Do we backport this or do we close the issue? |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 19, 2024
|
GH-120729 is a backport of this pull request to the 3.13 branch. |
Member
I didn't know that 3.13 was affected. I backported the change. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…0727) Fix compiler warnings on is_core_module() and check_interpreter_whence(): only define them when assertions are built.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…0727) Fix compiler warnings on is_core_module() and check_interpreter_whence(): only define them when assertions are built.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…0727) Fix compiler warnings on is_core_module() and check_interpreter_whence(): only define them when assertions are built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are only used in assertions.
warning: unused function 'is_core_module' [-Wunused-function]#120726