Skip to content

Clarify Asyncio subprocesses page in docs#12072

Closed
wesinator wants to merge 1 commit into
python:masterfrom
wesinator:patch-1
Closed

Clarify Asyncio subprocesses page in docs#12072
wesinator wants to merge 1 commit into
python:masterfrom
wesinator:patch-1

Conversation

@wesinator

Copy link
Copy Markdown
Contributor

Better distinguish Asyncio subprocesses docs page from subprocess in page title

Better distinguish Asyncio subprocesses docs page from subprocess
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@asvetlov

asvetlov commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

The doc page is entirely about asyncio.
I doubt if we need to add a prefix here

@wesinator

Copy link
Copy Markdown
Contributor Author

The doc page is entirely about asyncio.
I doubt if we need to add a prefix here

It's mainly for the page title
image

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Thanks for you contribution!

I agree with @asvetlov the page is already of asyncio,
I think that is understood that subprocess is for asyncio.

@eamanu

eamanu commented Apr 7, 2019

Copy link
Copy Markdown
Contributor

Travis fail because the new title overline is too short.

@csabella

Copy link
Copy Markdown
Contributor

@wesinator, thank you for the suggestion, but I'm going to close this based on @asvetlov's review.

@csabella csabella closed this Apr 10, 2019
@wesinator wesinator deleted the patch-1 branch April 10, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants