Skip to content

gh-118710: IPv*Address class properties#120698

Merged
encukou merged 8 commits into
python:mainfrom
nineteendo:IPv4Address-class-properties
Sep 4, 2024
Merged

gh-118710: IPv*Address class properties#120698
encukou merged 8 commits into
python:mainfrom
nineteendo:IPv4Address-class-properties

Conversation

@nineteendo

@nineteendo nineteendo commented Jun 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2024
Closed
nineteendo
nineteendo commented Jun 18, 2024
View reviewed changes
Comment thread Lib/ipaddress.py Outdated
@nineteendo
nineteendo marked this pull request as ready for review June 18, 2024 14:51
gpshead
gpshead previously requested changes Jun 18, 2024
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .. versionchanged:: 3.14 annotations to the Doc/library/ipaddress.rst description of these attributes mentioning that they are now available on the class as well as instances.

Comment thread Lib/ipaddress.py Outdated
@bedevere-app

bedevere-app Bot commented Jun 18, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nineteendo

nineteendo commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

gpshead, I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented Jun 19, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from gpshead June 19, 2024 05:54
abacabadabacaba
abacabadabacaba reviewed Jun 19, 2024
View reviewed changes
Comment thread Lib/ipaddress.py Outdated
@encukou
encukou dismissed gpshead’s stale review September 4, 2024 13:49

The requested change was made.

encukou
encukou approved these changes Sep 4, 2024
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@encukou
encukou merged commit c530ce1 into python:main Sep 4, 2024
@nineteendo
nineteendo deleted the IPv4Address-class-properties branch September 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@gpshead gpshead Awaiting requested review from gpshead
+1 more reviewer
@abacabadabacaba abacabadabacaba abacabadabacaba left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nineteendo @gpshead @encukou @abacabadabacaba