Skip to content

bpo-36052: Raise a SyntaxError when we assign a value to __debug__ #11958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 6 commits into from
Feb 21, 2019
Merged

bpo-36052: Raise a SyntaxError when we assign a value to __debug__ #11958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a04764
bpo-36052: Raise a SyntaxError when we assign a value to __debug__
matrixise Feb 20, 2019
a5f32ad
Add Pablo
matrixise Feb 20, 2019
2836c4f
Move the doctest after __debug__ = 1
matrixise Feb 20, 2019
5d9a61a
Update test_syntax.py
matrixise Feb 20, 2019
16bd68b
Update 2019-02-20-17-57-31.bpo-36052.l8lJSi.rst
matrixise Feb 20, 2019
b08f0ec
Update 2019-02-20-17-57-31.bpo-36052.l8lJSi.rst
matrixise Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@
Traceback (most recent call last):
SyntaxError: cannot assign to __debug__

>>> (__debug__ := 1)
Traceback (most recent call last):
SyntaxError: cannot assign to __debug__

>>> f() = 1
Traceback (most recent call last):
SyntaxError: cannot assign to function call
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2019-02-20-17-57-31.bpo-36052.l8lJSi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Raise a :exc:`SyntaxError` when assigning a value to `__debug__` with the
Assignment Operator. Contributed by Stéphane Wirtel and Pablo Galindo.
2 changes: 1 addition & 1 deletion Python/ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ set_context(struct compiling *c, expr_ty e, expr_context_ty ctx, const node *n)
return 0;
break;
case Name_kind:
if (ctx == Store) {
if (ctx == Store || ctx == NamedStore) {
if (forbidden_name(c, e->v.Name.id, n, 0))
return 0; /* forbidden_name() calls ast_error() */
}
Expand Down