Skip to content

gh-115225: Raise error on unsupported ISO 8601 time strings #119339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pganssle merged 5 commits into from
Jun 5, 2024
Merged

gh-115225: Raise error on unsupported ISO 8601 time strings #119339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e10a84
gh-115225: Raise error on unsupported ISO 8601 time strings
benchatt May 21, 2024
9dc1e4c
📜🤖 Added by blurb_it.
blurb-it[bot] May 21, 2024
0ab8279
Update 2024-05-21-19-10-30.gh-issue-115225.eRmfJH.rst
benchatt May 22, 2024
e045d36
add test for datetime.time.fromisoformat parse change
benchatt May 22, 2024
188a6da
add name to ACKS
benchatt May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4412,6 +4412,8 @@ def test_fromisoformat_fails(self):
'12:30:45.123456-', # Extra at end of microsecond time
'12:30:45.123456+', # Extra at end of microsecond time
'12:30:45.123456+12:00:30a', # Extra at end of full time
'12.5', # Decimal mark at end of hour
'12:30,5', # Decimal mark at end of minute
]

for bad_str in bad_strs:
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ Greg Chapman
Mitch Chapman
Matt Chaput
William Chargin
Ben Chatterton
Yogesh Chaudhari
Gautam Chaudhuri
David Chaum
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-05-21-19-10-30.gh-issue-115225.eRmfJH.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Raise error on certain technically valid but pathological ISO 8601 strings passed to :meth:`datetime.time.fromisoformat` that were previously parsed incorrectly.
Comment thread
benchatt marked this conversation as resolved.
3 changes: 3 additions & 0 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,9 @@ parse_hh_mm_ss_ff(const char *tstr, const char *tstr_end, int *hour,
continue;
}
else if (c == '.' || c == ',') {
if (i < 2) {
return -3; // Decimal mark on hour or minute
}
break;
} else if (!has_separator) {
--p;
Expand Down