Skip to content

Fix version number in use_load_tests deprecation reference #119151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
May 22, 2024
Merged

Fix version number in use_load_tests deprecation reference #119151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,7 +1739,7 @@ unittest

* Undocumented :meth:`TestLoader.loadTestsFromModule
<unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests*
(deprecated and ignored since Python 3.2).
(deprecated and ignored since Python 3.5).
Copy link
Contributor

@blaisep blaisep May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thank you.
Could you put this in a .. deprecated:: 3.5 directive ?

Copy link
Contributor Author

@jacobtylerwalls jacobtylerwalls May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. I only see uses of that directive in the actual documentation relating to the method itself, not here in the changelog. I'm reluctant to add the first such directive in this /whatsnew directory.

Copy link
Contributor

@blaisep blaisep May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I guess this may be impacted by the bigger topic mentioned in #109843 (comment) having to do with moving deprecation and removal items out of news.


* An alias of the :class:`~unittest.TextTestResult` class:
``_TextTestResult`` (deprecated in Python 3.2).
Copy link
Contributor

@blaisep blaisep May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also be a candidate for ..deprecated :: 3.2

Expand Down