Skip to content

bpo-35899: Fix Enum handling of empty and weird strings#11891

Merged
miss-islington merged 7 commits into
python:masterfrom
bdbaraban:fix-issue-35899
Mar 3, 2019
Merged

bpo-35899: Fix Enum handling of empty and weird strings#11891
miss-islington merged 7 commits into
python:masterfrom
bdbaraban:fix-issue-35899

Conversation

@bdbaraban

@bdbaraban bdbaraban commented Feb 16, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: Maxwell maxwellpxt@gmail.com
Co-authored-by: Stéphane Wirtel stephane@wirtel.be

https://bugs.python.org/issue35899

@234761 @Maxpxt @matrixise
bpo-35899: Fix Enum handling of empty and weird strings
dab01b9 
Co-authored-by: Maxwell <maxwellpxt@gmail.com>
Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
matrixise
matrixise approved these changes Feb 18, 2019
View reviewed changes

@matrixise matrixise left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your contribution.

@matrixise

matrixise commented Feb 20, 2019

Copy link
Copy Markdown
Member

@ethanfurman do you want to review/merge this PR?

Have a nice day,

@ethanfurman ethanfurman self-assigned this Feb 21, 2019
ethanfurman
ethanfurman requested changes Feb 21, 2019
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! A couple more changes and this should be ready to go.

Comment thread Lib/test/test_enum.py Outdated
Comment thread Lib/test/test_enum.py Outdated
@bedevere-bot

bedevere-bot commented Feb 21, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bdbaraban

bdbaraban commented Feb 23, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

Thank you, Ethan. I've updated both files accordingly.

@bedevere-bot

bedevere-bot commented Feb 23, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman requested changes Mar 3, 2019
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor change and this PR is good to go! Nice work!

Comment thread Misc/NEWS.d/next/Library/2019-02-16-07-11-02.bpo-35899.cjfn5a.rst Outdated
@bedevere-bot

bedevere-bot commented Mar 3, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington

miss-islington commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

@bdbaraban: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 8b914d2 into python:master Mar 3, 2019
@miss-islington

miss-islington commented Mar 3, 2019

Copy link
Copy Markdown
Contributor

Thanks @bdbaraban for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2019
@bdbaraban @miss-islington
bpo-35899: Fix Enum handling of empty and weird strings (pythonGH-11891)
7b5c54d 
Co-authored-by: Maxwell <maxwellpxt@gmail.com>
Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <34765317+bdbaraban@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Mar 3, 2019

Copy link
Copy Markdown

GH-12150 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Mar 3, 2019

Copy link
Copy Markdown

GH-12151 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2019
@bdbaraban @miss-islington
bpo-35899: Fix Enum handling of empty and weird strings (pythonGH-11891)
6d079ff 
Co-authored-by: Maxwell <maxwellpxt@gmail.com>
Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <34765317+bdbaraban@users.noreply.github.com>
@bdbaraban
bdbaraban deleted the fix-issue-35899 branch March 3, 2019 22:28
@remilapeyre remilapeyre mentioned this pull request Mar 6, 2019
Closed
miss-islington added a commit that referenced this pull request Mar 8, 2019
@miss-islington @bdbaraban
bpo-35899: Fix Enum handling of empty and weird strings (GH-11891)
8755f0a 
Co-authored-by: Maxwell <maxwellpxt@gmail.com>
Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <34765317+bdbaraban@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes
@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bdbaraban @matrixise @bedevere-bot @miss-islington @ethanfurman @the-knights-who-say-ni @234761