bpo-35992: Use PySequence_GetItem only if sq_item is not NULL#11857
Merged
Conversation
eamanu
approved these changes
Feb 14, 2019
eamanu
left a comment
eamanu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I test it and work ok for me.
serhiy-storchaka
approved these changes
Feb 17, 2019
Co-Authored-By: ilevkivskyi <levkivskyi@gmail.com>
Contributor
|
Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2019
…GH-11857) Not using `__class_getitem__()` fallback if there is a non-subcriptable metaclass was caused by a certain asymmetry between how `PySequenceMethods` and `PyMappingMethods` are used in `PyObject_GetItem`. This PR removes this asymmetry. No tests failed, so I assume it was not intentional. (cherry picked from commit ac28147) Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
|
GH-11910 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 17, 2019
Not using `__class_getitem__()` fallback if there is a non-subcriptable metaclass was caused by a certain asymmetry between how `PySequenceMethods` and `PyMappingMethods` are used in `PyObject_GetItem`. This PR removes this asymmetry. No tests failed, so I assume it was not intentional. (cherry picked from commit ac28147) Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using
__class_getitem__()fallback if there is a non-subcriptable metaclass was caused by a certain asymmetry between howPySequenceMethodsandPyMappingMethodsare used inPyObject_GetItem. This PR removes this assymetry. No tests failed, so I assume it was not intentional.https://bugs.python.org/issue35992