Skip to content

[3.12] gh-118235: Skip RAISE_SYNTAX_ERROR rules in the grammar spec (GH-118237)#118309

Merged
encukou merged 1 commit into
python:3.12from
miss-islington:backport-ef940de-3.12
Apr 26, 2024
Merged

[3.12] gh-118235: Skip RAISE_SYNTAX_ERROR rules in the grammar spec (GH-118237)#118309
encukou merged 1 commit into
python:3.12from
miss-islington:backport-ef940de-3.12

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

(cherry picked from commit ef940de)

Co-authored-by: Petr Viktorin encukou@gmail.com


📚 Documentation preview 📚: https://cpython-previews--118309.org.readthedocs.build/

…ythonGH-118237)

(cherry picked from commit ef940de)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou

encukou commented Apr 26, 2024

Copy link
Copy Markdown
Member

I didn't check the diff of the rendered docs page yet; waiting for the automation to prepare the docs.

@nineteendo

nineteendo commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

Edit: might not be possible if it's not your pull request.

@encukou

encukou commented Apr 26, 2024

Copy link
Copy Markdown
Member

The diff checks out; the for_if_clause seen in the original PR is new in 3.13.

@@ -498,9 +498,7 @@
 
 type_param:
     | NAME [type_param_bound] 
-    | '*' NAME ':' expression 
     | '*' NAME 
-    | '**' NAME ':' expression 
     | '**' NAME 
 
 type_param_bound: ':' expression 
@@ -801,7 +799,6 @@
 
 starred_expression:
     | '*' expression 
-    | '*' 
 
 kwarg_or_starred:
     | NAME '=' expression 

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

I don't see how it's better than the label that does the same thing.

@encukou
encukou merged commit db47460 into python:3.12 Apr 26, 2024
@miss-islington
miss-islington deleted the backport-ef940de-3.12 branch January 2, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants