Skip to content

gh-118216: Don't consider dotted __future__ imports #118267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
May 2, 2024
Merged

gh-118216: Don't consider dotted __future__ imports #118267

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfa0f3e
Add dotted import check in `future.c`
thatbirdguythatuknownot Apr 25, 2024
042554a
Add dotted import check in `compile.c`
thatbirdguythatuknownot Apr 25, 2024
536881e
Add tests for dotted imports of `__future__`
thatbirdguythatuknownot Apr 25, 2024
46c8290
Fix dotted import tests
thatbirdguythatuknownot Apr 25, 2024
62d8487
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 25, 2024
9b908ee
Fix Markdown
thatbirdguythatuknownot Apr 25, 2024
019ef6f
Add entry to What's New in 3.13
thatbirdguythatuknownot May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add dotted import check in future.c
  • Loading branch information
@thatbirdguythatuknownot
thatbirdguythatuknownot committed May 2, 2024
commit cfa0f3e5d2015c044fa3674ddf264636ebeecdf4
2 changes: 1 addition & 1 deletion Python/future.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ future_parse(_PyFutureFeatures *ff, mod_ty mod, PyObject *filename)
* are another future statement and a doc string.
*/

if (s->kind == ImportFrom_kind) {
if (s->kind == ImportFrom_kind && s->v.ImportFrom.level == 0) {
identifier modname = s->v.ImportFrom.module;
if (modname &&
_PyUnicode_EqualToASCIIString(modname, "__future__")) {
Expand Down