Skip to content

gh-117658: Fix check_dump_traceback_threads in free-threaded build #117659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Apr 9, 2024
Merged

gh-117658: Fix check_dump_traceback_threads in free-threaded build #117659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1484023
gh-117658: Fix check_dump_traceback_threads in free-threaded build
colesbury Apr 8, 2024
f2ed8d0
Add comment
colesbury Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,10 +575,12 @@ def run(self):
lineno = 8
else:
lineno = 10
# When the traceback is dumped, the waiter thread may be in the
# `self.running.set()` call or in `self.stop.wait()`.
regex = r"""
^Thread 0x[0-9a-f]+ \(most recent call first\):
(?: File ".*threading.py", line [0-9]+ in [_a-z]+
){{1,3}} File "<string>", line 23 in run
){{1,3}} File "<string>", line (?:22|23) in run
Copy link
Contributor

@erlend-aasland erlend-aasland Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might a bit puzzling to future readers... Perhaps we should add a short comment about this above the regex?

File ".*threading.py", line [0-9]+ in _bootstrap_inner
File ".*threading.py", line [0-9]+ in _bootstrap

Expand Down