Skip to content

gh-117142: ctypes: Clean up globals-to-fix.tsv #117544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 4 commits into from
May 22, 2024
Merged

gh-117142: ctypes: Clean up globals-to-fix.tsv #117544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccce574
remove migrated globals
neonene Apr 4, 2024
2c752b3
Merge branch 'main' into updtsv
encukou May 22, 2024
242c18b
Remove unused extern definitions from the internal header
encukou May 22, 2024
fbbbabb
Remove unneeded entries from ignored.tsv
encukou May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Modules/_ctypes/ctypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,14 +427,8 @@ struct basespec {
char *adr;
};

extern char basespec_string[];

extern ffi_type *_ctypes_get_ffi_type(ctypes_state *st, PyObject *obj);

extern char *_ctypes_conversion_encoding;
extern char *_ctypes_conversion_errors;


extern void _ctypes_free_closure(void *);
extern void *_ctypes_alloc_closure(void);

Expand Down
44 changes: 0 additions & 44 deletions Tools/c-analyzer/cpython/globals-to-fix.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,37 +354,6 @@ Modules/_testclinic.c - TestClass -
##-----------------------
## static types

Modules/_ctypes/_ctypes.c - PyCArrayType_Type -
Modules/_ctypes/_ctypes.c - PyCArray_Type -
Modules/_ctypes/_ctypes.c - PyCData_Type -
Modules/_ctypes/_ctypes.c - PyCFuncPtrType_Type -
Modules/_ctypes/_ctypes.c - PyCFuncPtr_Type -
Modules/_ctypes/_ctypes.c - PyCPointerType_Type -
Modules/_ctypes/_ctypes.c - PyCPointer_Type -
Modules/_ctypes/_ctypes.c - PyCSimpleType_Type -
Modules/_ctypes/_ctypes.c - PyCStructType_Type -
Modules/_ctypes/_ctypes.c - Simple_Type -
Modules/_ctypes/_ctypes.c - Struct_Type -
Modules/_ctypes/_ctypes.c - UnionType_Type -
Modules/_ctypes/_ctypes.c - Union_Type -
Modules/_ctypes/callproc.c - PyCArg_Type -
Modules/_ctypes/ctypes.h - PyCArg_Type -
Modules/_ctypes/ctypes.h - PyCArrayType_Type -
Modules/_ctypes/ctypes.h - PyCArray_Type -
Modules/_ctypes/ctypes.h - PyCData_Type -
Modules/_ctypes/ctypes.h - PyCFuncPtrType_Type -
Modules/_ctypes/ctypes.h - PyCFuncPtr_Type -
Modules/_ctypes/ctypes.h - PyCPointerType_Type -
Modules/_ctypes/ctypes.h - PyCPointer_Type -
Modules/_ctypes/ctypes.h - PyCSimpleType_Type -
Modules/_ctypes/ctypes.h - PyCStgDict_Type -
Modules/_ctypes/ctypes.h - PyCStructType_Type -
Modules/_ctypes/ctypes.h - PyExc_ArgError -
Modules/_ctypes/ctypes.h - _ctypes_conversion_encoding -
Modules/_ctypes/ctypes.h - _ctypes_conversion_errors -
Modules/_ctypes/ctypes.h - _ctypes_ptrtype_cache -
Modules/_ctypes/ctypes.h - basespec_string -
Modules/_ctypes/stgdict.c - PyCStgDict_Type -
Modules/_cursesmodule.c - PyCursesWindow_Type -
Modules/_datetimemodule.c - PyDateTime_DateTimeType -
Modules/_datetimemodule.c - PyDateTime_DateType -
Expand All @@ -410,32 +379,19 @@ Modules/_tkinter.c - Tktt_Type -
Modules/xxlimited_35.c - Xxo_Type -

## exception types
Modules/_ctypes/_ctypes.c - PyExc_ArgError -
Modules/_cursesmodule.c - PyCursesError -
Modules/_tkinter.c - Tkinter_TclError -
Modules/xxlimited_35.c - ErrorObject -
Modules/xxmodule.c - ErrorObject -

##-----------------------
## cached - initialized once

## manually cached PyUnicodeOjbect
Modules/_ctypes/callproc.c _ctypes_get_errobj error_object_name -
Modules/_ctypes/_ctypes.c CreateSwappedType swapped_suffix -

##-----------------------
## other

## initialized once
Modules/_ctypes/_ctypes.c - _unpickle -
Modules/_ctypes/_ctypes.c PyCArrayType_from_ctype array_cache -
Modules/_cursesmodule.c - ModDict -
Modules/_datetimemodule.c datetime_strptime module -

## state
Modules/_ctypes/_ctypes.c - _ctypes_ptrtype_cache -
Modules/_ctypes/_ctypes.c - global_state -
Modules/_ctypes/ctypes.h - global_state -
Modules/_datetimemodule.c - _datetime_global_state -
Modules/_tkinter.c - tcl_lock -
Modules/_tkinter.c - excInCmd -
Expand Down
3 changes: 0 additions & 3 deletions Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,16 +395,13 @@ Python/optimizer.c - cold_exits_initialized -
##-----------------------
## test code

Modules/_ctypes/_ctypes_test.c - _ctypes_test_slots -
Modules/_ctypes/_ctypes_test.c - _ctypes_testmodule -
Modules/_ctypes/_ctypes_test.c - _xxx_lib -
Modules/_ctypes/_ctypes_test.c - an_integer -
Modules/_ctypes/_ctypes_test.c - bottom -
Modules/_ctypes/_ctypes_test.c - last_tf_arg_s -
Modules/_ctypes/_ctypes_test.c - last_tf_arg_u -
Modules/_ctypes/_ctypes_test.c - last_tfrsuv_arg -
Modules/_ctypes/_ctypes_test.c - left -
Modules/_ctypes/_ctypes_test.c - module_methods -
Modules/_ctypes/_ctypes_test.c - my_eggs -
Modules/_ctypes/_ctypes_test.c - my_spams -
Modules/_ctypes/_ctypes_test.c - right -
Expand Down