Skip to content

gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes #117432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eendebakpt wants to merge 3 commits into from
Closed

gh-117431: Improve performance of startswith, endswith, count and find methods for strings and bytes #117432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8670190
Improve performance of startswith, endswith for strings and bytes
eendebakpt Apr 1, 2024
dba79ad
fix refleak
eendebakpt Apr 1, 2024
f252769
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-04-01-21-15-35.gh-issue-117431.UBT4zj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of startswith, endswith, count and find methods for strings and bytes.
9 changes: 9 additions & 0 deletions Objects/stringlib/find.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,15 @@ STRINGLIB(parse_args_finds)(const char * function_name, PyObject *args,
Py_ssize_t tmp_start = 0;
Py_ssize_t tmp_end = PY_SSIZE_T_MAX;
PyObject *obj_start=Py_None, *obj_end=Py_None;

if (PyTuple_GET_SIZE(args) == 1) {
// fast path
*start = tmp_start;
*end = tmp_end;
*subobj = PyTuple_GET_ITEM(args, 0);
return 1;
}

char format[FORMAT_BUFFER_SIZE] = "O|OO:";
size_t len = strlen(format);

Expand Down