Skip to content

gh-117352: Handle /:/ for ntpath.isabs #117362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineteendo wants to merge 6 commits into from
Closed

gh-117352: Handle /:/ for ntpath.isabs #117362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdbb595
Handle `/:` for `ntpath.isabs`
nineteendo Mar 29, 2024
fec0a93
Speedup `ntpath.isabs`
nineteendo Mar 29, 2024
cf62868
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 29, 2024
2950921
Simplify check
nineteendo Mar 30, 2024
941c276
Update 2024-03-29-07-34-39.gh-issue-117352.-34fR4.rst
nineteendo Mar 31, 2024
9abff6a
Revert `str.startswith()`
nineteendo Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/ntpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,16 @@ def isabs(s):
sep = b'\\'
altsep = b'/'
colon_sep = b':\\'
double_sep = b'\\\\'
else:
sep = '\\'
altsep = '/'
colon_sep = ':\\'
double_sep = '\\\\'
s = s[:3].replace(altsep, sep)
# Absolute: UNC, device, and paths with a drive and root.
return s.startswith(colon_sep, 1) or s.startswith(double_sep)

if s.startswith(sep):
return s.startswith(sep, 1)
else:
return s.startswith(colon_sep, 1)

# Join two (or more) paths.
def join(path, *paths):
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_ntpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,12 @@ def test_isabs(self):
tester('ntpath.isabs("c:/foo/bar")', 1)
tester('ntpath.isabs("\\\\conky\\mountpoint\\")', 1)

# gh-44626: paths with only a drive or root are not absolute.
# gh-44626 & gh-117352: paths with only a drive or root are not absolute.
tester('ntpath.isabs("\\foo\\bar")', 0)
tester('ntpath.isabs("/foo/bar")', 0)
tester('ntpath.isabs("c:foo\\bar")', 0)
tester('ntpath.isabs("c:foo/bar")', 0)
tester('ntpath.isabs("/:/foo/bar")', 0)

# gh-96290: normal UNC paths and device paths without trailing backslashes
tester('ntpath.isabs("\\\\conky\\mountpoint")', 1)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-03-29-07-34-39.gh-issue-117352.-34fR4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Handle ``/:/`` for :func:`ntpath.isabs`.