Skip to content

gh-111926: Avoid locking in PyType_IsSubtype #117275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 5 commits into from
Mar 29, 2024
+1 −8
Merged

gh-111926: Avoid locking in PyType_IsSubtype #117275

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed1e37f
Use QSBR to avoid locking in PyType_IsSubtype
mpage Mar 26, 2024
ce38dbf
Make sure GC actually delays freeing
mpage Mar 27, 2024
21b40de
Refactor PyType_IsSubtype and _PyType_GetMRO
mpage Mar 27, 2024
0ee1aa3
Done add tuples tagged for delayed reclamation to free lists
mpage Mar 28, 2024
e5c7b59
Temporarily remove thread safety when performing PyType_IsSubtype
mpage Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,14 +2341,7 @@ is_subtype_with_mro(PyObject *a_mro, PyTypeObject *a, PyTypeObject *b)
int
PyType_IsSubtype(PyTypeObject *a, PyTypeObject *b)
{
#ifdef Py_GIL_DISABLED
PyObject *mro = _PyType_GetMRO(a);
int res = is_subtype_with_mro(mro, a, b);
Py_XDECREF(mro);
return res;
#else
return is_subtype_with_mro(lookup_tp_mro(a), a, b);
#endif
return is_subtype_with_mro(a->tp_mro, a, b);
}

/* Routines to do a method lookup in the type without looking in the
Expand Down