Skip to content

gh-66543: Add mimetypes.guess_file_type() #117258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
May 6, 2024
Merged

gh-66543: Add mimetypes.guess_file_type() #117258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a86c8dd
gh-66543: Add mimetypes.guess_file_type()
serhiy-storchaka Mar 26, 2024
bd205f6
Address review comments.
serhiy-storchaka Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comments.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Mar 26, 2024
commit bd205f64f9fcbcdcdf425f1c7bf04157ef918218
6 changes: 3 additions & 3 deletions Doc/library/mimetypes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ the information :func:`init` sets up.
.. versionchanged:: 3.8
Added support for *url* being a :term:`path-like object`.

.. versionchanged:: 3.13
Passing a file path instead of URL is deprecated.
.. deprecated:: 3.13
Passing a file path instead of URL is :term:`soft deprecated`.
Use :func:`guess_file_type` for this.


Expand Down Expand Up @@ -253,7 +253,7 @@ than one MIME-type database; it provides an interface similar to the one of the
the object.


.. method:: MimeTypes.guess_type(url, strict=True)
.. method:: MimeTypes.guess_file_type(path, *, strict=True)

Similar to the :func:`guess_file_type` function, using the tables stored
as part of the object.
Expand Down
4 changes: 2 additions & 2 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ mimetypes
---------

* Add the :func:`~mimetypes.guess_file_type` function which works with file path.
Passing file path instead of URL in :func:`~mimetypes.guess_type` is deprecated.
Passing file path instead of URL in :func:`~mimetypes.guess_type` is :term:`soft deprecated`.
(Contributed by Serhiy Storchaka in :gh:`66543`.)

mmap
Expand Down Expand Up @@ -892,7 +892,7 @@ Deprecated
and was only useful for Jython support.
(Contributed by Nikita Sobolev in :gh:`116349`.)

* Passing file path instead of URL in :func:`~mimetypes.guess_type` is deprecated.
* Passing file path instead of URL in :func:`~mimetypes.guess_type` is :term:`soft deprecated`.
Use :func:`~mimetypes.guess_file_type` instead.
(Contributed by Serhiy Storchaka in :gh:`66543`.)

Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2024-03-26-15-29-39.gh-issue-66543.OZBhU5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Add the :func:`mimetypes.guess_file_type` function which works with file
path. Passing file path instead of URL in :func:`~mimetypes.guess_type` is
deprecated.
:term:`soft deprecated`.