bpo-35780: Fix errors in lru_cache() C code#11715
Merged
Merged
Conversation
rhettinger
added
type-bug
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 31, 2019
…call (pythonGH-11715) (cherry picked from commit ffdf1c3) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
|
GH-11716 is a backport of this pull request to the 3.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR fixed the location of the misses update in the bounded_lru_cache_wrapper(). This PR fixes the other two wrappers as well. Misses now has a consistent definition of being the number of times the argument pattern was not found in the cache.
https://bugs.python.org/issue35780