Skip to content

[3.7] bpo-35720: Fixing a memory leak in pymain_parse_cmdline_impl() (GH-11528)#11648

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-35ca182-3.7
Jan 22, 2019
Merged

[3.7] bpo-35720: Fixing a memory leak in pymain_parse_cmdline_impl() (GH-11528)#11648
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-35ca182-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 22, 2019

Copy link
Copy Markdown
Contributor

When the loop in the pymain_read_conf function in this same file
calls pymain_init_cmdline_argv() a 2nd time, the pymain->command
buffer of wchar_t is overriden and the previously allocated memory
is never freed.
(cherry picked from commit 35ca182)

Co-authored-by: Lucas Cimon lucas.cimon@gmail.com

https://bugs.python.org/issue35720

…nGH-11528)

When the loop in the pymain_read_conf function in this same file
calls pymain_init_cmdline_argv() a 2nd time, the pymain->command
buffer of wchar_t is overriden and the previously allocated memory
is never freed.
(cherry picked from commit 35ca182)

Co-authored-by: Lucas Cimon <lucas.cimon@gmail.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@Lucas-C and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit f71e743 into python:3.7 Jan 22, 2019
@miss-islington
miss-islington deleted the backport-35ca182-3.7 branch January 22, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants