Skip to content

bpo-35168: Make shlex.punctuation_chars read-only#11631

Merged
vsajip merged 4 commits into
python:masterfrom
ashkop:bpo-35168
Sep 11, 2019
Merged

bpo-35168: Make shlex.punctuation_chars read-only#11631
vsajip merged 4 commits into
python:masterfrom
ashkop:bpo-35168

Conversation

@ashkop

@ashkop ashkop commented Jan 21, 2019 •
edited by vsajip
Loading

Copy link
Copy Markdown
Contributor

Make shlex.punctuation_chars read-only and change the docs accordingly

https://bugs.python.org/issue35168

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 21, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@ashkop ashkop changed the title bpo-35168: Make shlex.punctuation_chards read-only bpo-35168: Make shlex.punctuation_chars read-only Jan 21, 2019
@tirkarthi

tirkarthi commented Jan 21, 2019

Copy link
Copy Markdown
Member

I think this requires a NEWS entry since punctuation_chars is now made as a read-only property. Please refer to NEWS entry guide https://devguide.python.org/committing/?highlight=blurb#what-s-new-and-news-entries

@ashkop

ashkop commented Jan 22, 2019

Copy link
Copy Markdown
Contributor Author

Sure, thanks. Added the NEWS.d entry.

@vsajip
vsajip merged commit 972cf5c into python:master Sep 11, 2019
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

@vsajip: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @ashkop for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks @ashkop for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Sorry, @ashkop and @vsajip, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 972cf5c06a5ba16ad243a442dbb9c15307fbed95 3.7

@miss-islington

miss-islington commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Sorry @ashkop and @vsajip, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 972cf5c06a5ba16ad243a442dbb9c15307fbed95 3.8

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15926 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

GH-15927 is a backport of this pull request to the 3.8 branch.

vsajip added a commit that referenced this pull request Sep 11, 2019
@vsajip @ashkop
[3.7] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (G…
aca878e 
…H-15926)

(cherry picked from commit 972cf5c)

Co-authored-by: Alex <a.v.shkop@gmail.com>
vsajip added a commit that referenced this pull request Sep 11, 2019
@vsajip @ashkop
[3.8] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (G…
3b92ddb 
…H-15927)

(cherry picked from commit 972cf5c)

Co-authored-by: Alex <a.v.shkop@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@ashkop @DinoV
bpo-35168: Make shlex.punctuation_chars read-only (python#11631)
e393ded 
* bpo-35168: Documentation about shlex.punctuation_chars now states that it should be set in __init__.py

* bpo-35168: Convert shlex.punctuation_chars to read-only property

* Add NEWS.d entry
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@ashkop @websurfer5
bpo-35168: Make shlex.punctuation_chars read-only (python#11631)
483f83c 
* bpo-35168: Documentation about shlex.punctuation_chars now states that it should be set in __init__.py

* bpo-35168: Convert shlex.punctuation_chars to read-only property

* Add NEWS.d entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@m-aciek m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vsajip vsajip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ashkop @the-knights-who-say-ni @tirkarthi @bedevere-bot @miss-islington @m-aciek @vsajip