Skip to content

gh-116100: Add test arg to ast.If and op arg to ast.BoolOp calls #116101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 1 commit into from
Feb 29, 2024
Merged

gh-116100: Add test arg to ast.If and op arg to ast.BoolOp calls #116101

JelleZijlstra merged 1 commit into from
Feb 29, 2024
+2 −2

Conversation

@Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Feb 29, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 29, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 29, 2024
JelleZijlstra
JelleZijlstra approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We could perhaps switch to simpler node types that don't require children, but this should be fine.

@JelleZijlstra JelleZijlstra merged commit 6a86030 into python:main Feb 29, 2024
@Eclips4 Eclips4 deleted the issue-116100 branch February 29, 2024 17:12
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Eclips4 @woodruffw
pythongh-116100: Add test arg to ast.If and op arg to `ast.Bool…
5eac9bc 
…Op` calls (python#116101)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@Eclips4 @adorilson
pythongh-116100: Add test arg to ast.If and op arg to `ast.Bool…
947ff6e 
…Op` calls (python#116101)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Eclips4 @diegorusso
pythongh-116100: Add test arg to ast.If and op arg to `ast.Bool…
514e6e7 
…Op` calls (python#116101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eclips4 @JelleZijlstra @sobolevn