bpo-35749: Don't log exception if event loop wakeup pipe is full#11577
bpo-35749: Don't log exception if event loop wakeup pipe is full#11577asvetlov wants to merge 3 commits into
Conversation
| wakeup = False | ||
| while True: | ||
| try: | ||
| data = self._ssock.recv(4096) |
There was a problem hiding this comment.
Can use sock.recv_into() here. Not sure if it worth to change
vstinner
left a comment
There was a problem hiding this comment.
" bpo-35749: Don't log exception if event loop wakeup pipe is full #11577" title is inaccurate. Your change just completely rewrite how asyncio handles signals.
Ignoring logs when the pipe is full is a weak rationale to rewrite signal handling. Please dig into the history to see why asyncio is written like that. I recall vaguely that there were complex race conditions on FreeBSD.
I'm not against "experimenting" new way to handle signals, but it would need a better rationale.
|
When you're done making the requested changes, leave the comment: |
|
I'll change the title and changelog text if we decide to land the change. Let' me explain the motivation better:
|
https://bugs.python.org/issue35749