Skip to content

[3.7] bpo-35066: _dateime.datetime.strftime copies trailing '%' (GH-10692)#11550

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-454b3d4-3.7
Jan 14, 2019
Merged

[3.7] bpo-35066: _dateime.datetime.strftime copies trailing '%' (GH-10692)#11550
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-454b3d4-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

Previously, calling the strftime() method on a datetime object with a
trailing '%' in the format string would result in an exception. However,
this only occured when the datetime C module was being used; the python
implementation did not match this behavior. Datetime is now PEP-399
compliant, and will not throw an exception on a trailing '%'.
(cherry picked from commit 454b3d4)

Co-authored-by: MichaelSaah mike.saah@gmail.com

https://bugs.python.org/issue35066

…0692)

Previously, calling the strftime() method on a datetime object with a
trailing '%' in the format string would result in an exception. However,
this only occured when the datetime C module was being used; the python
implementation did not match this behavior. Datetime is now PEP-399
compliant, and will not throw an exception on a trailing '%'.
(cherry picked from commit 454b3d4)

Co-authored-by: MichaelSaah <mike.saah@gmail.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@michaelsaah and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 26122de into python:3.7 Jan 14, 2019
@miss-islington
miss-islington deleted the backport-454b3d4-3.7 branch January 14, 2019 10:41
@miss-islington

Copy link
Copy Markdown
Contributor Author

@michaelsaah and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants