bpo-34294: re module, fix wrong capturing groups in rare cases#11546
Merged
Conversation
ghost
changed the title
ghost
changed the title
ghost
changed the title
ghost
changed the title
Need to reset capturing groups between two `SRE(match)` callings in loops, this fixes wrong capturing groups in rare cases. Other changes in this commit: * Emit `SRE_ERROR_STATE` when reach impossible code path, rather than return a match failure silently. * Add two test-cases to `test_zerowidth()`. * Add a missing index in `re.rst`. * Remove an outdated FIXME comment in `_sre.c`.
ghost
changed the title
serhiy-storchaka
self-requested a review
February 18, 2019 08:21
Member
|
LGTM. Just rewrite a news entry. |
serhiy-storchaka
approved these changes
Feb 18, 2019
serhiy-storchaka
added
type-bug
Contributor
|
Thanks @animalize for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 18, 2019
…onGH-11546) Need to reset capturing groups between two SRE(match) callings in loops, this fixes wrong capturing groups in rare cases. Also add a missing index in re.rst. (cherry picked from commit 4a7f44a) Co-authored-by: animalize <animalize@users.noreply.github.com>
|
GH-11919 is a backport of this pull request to the 3.7 branch. |
ghost
mentioned this pull request
ghost
deleted the
fix_re
branch
February 18, 2019 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRE(match)doesn't reset capturing groups, we need to reset them between twoSRE(match)callings in loops. Otherwise the previousSRE(match)'s capturing groups may intrude upon the currentSRE(match).re.rsthttps://bugs.python.org/issue34294