-
-
Notifications
You must be signed in to change notification settings - Fork 35k
gh-115323: Add meaningful error message for using bytearray.extend with str #115332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
terryjreedy
merged 14 commits into
python:main
from
jayasting98:115323-bytearray-extend-add-meaningful-error-message
Feb 24, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
90519db
Add meaningful error message for using bytearray.extend with str
jayasting98 278b247
Add NEWS entry
jayasting98 a268ed5
Perform str check after TypeError is raised
jayasting98 f4e0561
Reword error message
jayasting98 42665ae
Change error message
jayasting98 99555cf
Improve accuracy of error message
jayasting98 56d86d0
Update Lib/test/test_bytes.py
terryjreedy ffa6508
Merge branch 'main' into 115323-bytearray-extend-add-meaningful-error…
terryjreedy 84c5419
Update Lib/test/test_bytes.py
terryjreedy 07c4a5a
Update Lib/test/test_bytes.py
terryjreedy bd094a7
Update Lib/test/test_bytes.py
terryjreedy 53322f8
Merge branch 'main' into 115323-bytearray-extend-add-meaningful-error…
terryjreedy dec335b
Update Objects/bytearrayobject.c
terryjreedy 8de6ff3
Merge branch 'main' into 115323-bytearray-extend-add-meaningful-error…
terryjreedy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2024-02-12-23-29-17.gh-issue-115323.3t6687.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Make error message more meaningful for when :meth:`bytearray.extend` is | ||
| called with a :class:`str` object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.