gh-115077: Make some Argument Clinic error messages more helpful #115078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Feb 6, 2024
Tools/clinic/clinic.py
Outdated
| if len(args) > 2: | ||
| fail("Up to 2 critical section variables are supported") | ||
| fail("Only 2 critical section variables are supported; " | ||
| f"{len(args)} was given") |
Member
There was a problem hiding this comment.
Suggested change
| f"{len(args)} was given") | |
| f"{len(args)} were given") |
Contributor
Author
There was a problem hiding this comment.
Perhaps also print them out?
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Contributor
Author
|
@sobolevn, feel free to contribute to this branch/PR. |
Tools/clinic/clinic.py
Outdated
Comment on lines
838
to
839
| fail("Cannot specify multiple varargs; " | ||
| f"'*{parameters[vararg].name}' was already provided as parameter {vararg+1}") |
Member
There was a problem hiding this comment.
You refer to the same parameter by the name and the number.
But the conflict is between two varargs parameters[vararg].name (number vararg+1) and p.name (number i).
Contributor
Author
There was a problem hiding this comment.
Perhaps the number is not needed. I agree it is better if we refer to both parameters by name.
Contributor
Author
|
Perhaps 94e082e is overdoing it. |
Contributor
Author
|
I'll have to start this branch over again; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.