bpo-35689: IDLE: Add docstrings and unittests for colorizer.py#11472
Merged
Conversation
eamanu
approved these changes
Jan 9, 2019
Member
|
Test pass for me with 92% coverage. Will next look at details. |
Since 2002, cnf never None in tagdefs.
Add comments
This partial reverts proposed changes.
terryjreedy
approved these changes
Feb 19, 2019
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
I made the few minor changes I wanted, and intend to merge when CI passes again.
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2019
…nGH-11472) (cherry picked from commit ee0f927) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
|
GH-11925 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 19, 2019
) (cherry picked from commit ee0f927) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35689