Skip to content

gh-109653: Improve import time of importlib.metadata / email.utils #114664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
Jan 29, 2024
Merged

gh-109653: Improve import time of importlib.metadata / email.utils #114664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579644a
gh-109653: Improve import time of importlib.metadata / email.utils
hauntsaninja Jan 28, 2024
94fd0d7
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 28, 2024
3eefd32
comments
hauntsaninja Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/email/_parseaddr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'quote',
]

import time, calendar
import time

SPACE = ' '
EMPTYSTRING = ''
Expand Down Expand Up @@ -194,6 +194,9 @@ def mktime_tz(data):
# No zone info, so localtime is better assumption than GMT
return time.mktime(data[:8] + (-1,))
else:
# Delay the import, since mktime_tz is rarely used
import calendar

t = calendar.timegm(data)
return t - data[9]

Expand Down
5 changes: 4 additions & 1 deletion Lib/importlib/metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
import re
import abc
import csv
import sys
import json
import email
Expand Down Expand Up @@ -478,6 +477,10 @@ def make_file(name, hash=None, size_str=None):

@pass_none
def make_files(lines):
# Delay csv import, since Distribution.files is not as widely used
# as other parts of importlib.metadata
import csv

return starmap(make_file, csv.reader(lines))

@pass_none
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-01-28-00-48-12.gh-issue-109653.vF4exe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve import time of :mod:`importlib.metadata` and :mod:`email.utils`.