Skip to content

bpo-35551: encodings update#11446

Merged
csabella merged 3 commits into
python:masterfrom
epicfaace:bpo-35551
Jun 5, 2019
Merged

bpo-35551: encodings update#11446
csabella merged 3 commits into
python:masterfrom
epicfaace:bpo-35551

Conversation

@epicfaace

@epicfaace epicfaace commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. news?

@eamanu

eamanu commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

@epicfaace Please sign the CLA

@epicfaace

Copy link
Copy Markdown
Contributor Author

@eamanu I signed it yesterday, do you know how long it should take to update?

@vstinner

vstinner commented Jan 7, 2019

Copy link
Copy Markdown
Member

@eamanu I signed it yesterday, do you know how long it should take to update?

It can take a few days. Check the status in your bugs.python.org profile.

@epicfaace

Copy link
Copy Markdown
Contributor Author

@eamanu it's been updated as signed now.

@csabella
csabella requested a review from malemburg June 5, 2019 15:51
@csabella

csabella commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Requesting review from @malemburg based on question from @methane on the bug tracker.

@csabella

csabella commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

@epicfaace, thank you for the pull request and @malemburg, thank you for the approval.

@epicfaace
epicfaace deleted the bpo-35551 branch August 27, 2019 01:14
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants