Skip to content

gh-114083: apply optimization of LOAD_CONST instructions to the whole CFG before optimize_basic_block. #114408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 7 commits into from
Jan 22, 2024
Merged

gh-114083: apply optimization of LOAD_CONST instructions to the whole CFG before optimize_basic_block. #114408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
00ac451
gh-114083: apply folding of LOAD_CONST instructions to the whole CFG …
iritkatriel Jan 21, 2024
afd17e3
Merge branch 'main' into gh-114083
iritkatriel Jan 21, 2024
61fd0ee
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 22, 2024
d13b425
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 22, 2024
a10c22f
add comment
iritkatriel Jan 22, 2024
b3cb09b
Delete Misc/NEWS.d/next/Core and Builtins/2024-01-22-09-48-58.gh-issu…
iritkatriel Jan 22, 2024
28d6139
rename fold-->optimize
iritkatriel Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Lib/test/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,17 @@ def test_condition_expression_with_dead_blocks_compiles(self):
compile('if (5 if 5 else T): 0', '<eval>', 'exec')

def test_condition_expression_with_redundant_comparisons_compiles(self):
# See gh-113054
with self.assertWarns(SyntaxWarning):
compile('if 9<9<9and 9or 9:9', '<eval>', 'exec')
# See gh-113054, gh-114083
exprs = [
'if 9<9<9and 9or 9:9',
'if 9<9<9and 9or 9or 9:9',
'if 9<9<9and 9or 9or 9or 9:9',
'if 9<9<9and 9or 9or 9or 9or 9:9',
]
for expr in exprs:
with self.subTest(expr=expr):
with self.assertWarns(SyntaxWarning):
compile(expr, '<eval>', 'exec')

def test_dead_code_with_except_handler_compiles(self):
compile(textwrap.dedent("""
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-01-22-09-49-02.gh-issue-114083.hf1-ku.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Compiler applies folding of LOAD_CONST with following instruction in a separate pass before other optimisations. This enables jump threading in certain circumstances.
Loading