GH-114013: fix setting HOSTRUNNER for Tools/wasm/wasi.py#114097
Merged
brettcannon merged 6 commits intoJan 16, 2024
Conversation
brettcannon
requested review from
AlexWaygood and
JelleZijlstra
as code owners
January 16, 2024 18:53
AlexWaygood
removed their request for review
January 16, 2024 18:54
sobolevn
approved these changes
Jan 16, 2024
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
I agree with the recursion limit change, but I am not familiar with wasi.py enough to decide on this part! However, I am fully aware that you are :)
Member
Author
Well, I at least try to be. 😅 This one shows I'm still learning how cross-builds work. |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…ythonGH-114097) Also fix tests found failing under a pydebug build of WASI thanks to `make test` working due to this change.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ythonGH-114097) Also fix tests found failing under a pydebug build of WASI thanks to `make test` working due to this change.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ythonGH-114097) Also fix tests found failing under a pydebug build of WASI thanks to `make test` working due to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes failing tests under a pydebug build of WASI thanks to
make testnow working.make testdoesn't work w/ a WASI cross-build via (at least)Tools/wasm/wasi.py#114013