Skip to content

gh-114050: Fix crash when more than two arguments are passed to int() #114067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Jan 18, 2024
Merged

gh-114050: Fix crash when more than two arguments are passed to int() #114067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd6dc6
gh-114050: Remove typo format string in longobject
kcatss Jan 14, 2024
c644351
gh-114050: Add test case and NEWS entry
Eclips4 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_int.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def test_basic(self):


self.assertRaises(TypeError, int, 1, 12)
self.assertRaises(TypeError, int, "10", 2, 1)

self.assertEqual(int('0o123', 0), 83)
self.assertEqual(int('0x123', 16), 291)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-01-17-23-39-20.gh-issue-114050.Lnv1oq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix segmentation fault caused by an incorrect format string
in ``TypeError`` exception when more than two arguments are passed to ``int``.
2 changes: 1 addition & 1 deletion Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6171,7 +6171,7 @@ long_vectorcall(PyObject *type, PyObject * const*args,
return long_new_impl(_PyType_CAST(type), args[0], args[1]);
default:
return PyErr_Format(PyExc_TypeError,
"int expected at most 2 argument%s, got %zd",
"int expected at most 2 arguments, got %zd",
nargs);
}
}
Expand Down