Skip to content

bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler#11398

Merged
zware merged 6 commits into
python:masterfrom
geryogam:patch-4
Sep 11, 2019
Merged

bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler#11398
zware merged 6 commits into
python:masterfrom
geryogam:patch-4

Conversation

@geryogam

@geryogam geryogam commented Jan 2, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@tirkarthi

tirkarthi commented Jan 2, 2019

Copy link
Copy Markdown
Member

Please raise an issue in https://bugs.python.org for this PR to discuss this since it's a non-trivial change and would require tests.

@eamanu

eamanu commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

This seems a interest. I open a issue https://bugs.python.org/issue35640 to discuss this @tirkarthi @maggyero

eamanu
eamanu approved these changes Jan 2, 2019
View reviewed changes

@eamanu eamanu left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @maggyero Maybe you will need some Exception control.

@geryogam geryogam changed the title Allow passing PathLike arguments to SimpleHTTPRequestHandler bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler Jan 2, 2019
@JulienPalard

JulienPalard commented Mar 15, 2019

Copy link
Copy Markdown
Member

Hi @maggyero thanks for the PR!

Could you also provide a .. versionchanged:: in the documentation to tell about it, and a test?

@geryogam
geryogam force-pushed the patch-4 branch 3 times, most recently from 6558433 to 3afec10 Compare March 17, 2019 01:01
@geryogam

geryogam commented Mar 17, 2019

Copy link
Copy Markdown
Contributor Author

Could you also provide a .. versionchanged:: in the documentation to tell about it, and a test?

@JulienPalard Yes, done.

@geryogam

geryogam commented Sep 3, 2019

Copy link
Copy Markdown
Contributor Author

@JulienPalard I have made the requested changes. Please review again.

@zware

zware commented Sep 10, 2019

Copy link
Copy Markdown
Member

@maggyero Could you add a NEWS entry for this change?

@geryogam

geryogam commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

@zware Yes, done!

zware
zware requested changes Sep 11, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing that I'll commit myself if GitHub lets me, otherwise LGTM.

Comment thread Doc/library/http.server.rst Outdated
@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@geryogam @zware
Update Doc/library/http.server.rst
d8402f4 
Co-Authored-By: Zachary Ware <zachary.ware@gmail.com>
@geryogam

geryogam commented Sep 11, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from zware September 11, 2019 12:37
zware
zware approved these changes Sep 11, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zware
zware merged commit 781266e into python:master Sep 11, 2019
@zware

zware commented Sep 11, 2019

Copy link
Copy Markdown
Member

Thanks for the patch, @maggyero!

@geryogam
geryogam deleted the patch-4 branch September 11, 2019 13:09
@geryogam

geryogam commented Sep 11, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the review @zware!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@geryogam @DinoV
bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandl…
f29d990 
…er (pythonGH-11398)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@geryogam @websurfer5
bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandl…
19cc9f4 
…er (pythonGH-11398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
+1 more reviewer
@eamanu eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@geryogam @tirkarthi @eamanu @JulienPalard @zware @bedevere-bot @the-knights-who-say-ni