gh-113868: Add a number of MAP_* flags from macOS to module mmap#113869
Merged
Conversation
serhiy-storchaka
approved these changes
Jan 9, 2024
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM.
But I would sort all names after MAP_SHARED and MAP_PRIVATE (which are special) alphabetically. It helps to search if the name is supported in Python.
serhiy-storchaka
approved these changes
Jan 9, 2024
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Yet few suggestions.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
Jan 9, 2024
Comment on lines
+1
to
+6
| Added :data:`mmap.MAP_NORESERVE`, :data:`mmap.MAP_NOEXTEND`, | ||
| :data:`mmap.MAP_HASSEMAPHORE`, :data:`mmap.MAP_NOCACHE`, | ||
| :data:`mmap.MAP_JIT`, :data:`mmap.MAP_RESILIENT_CODESIGN`, | ||
| :data:`mmap.MAP_RESILIENT_MEDIA`, :data:`mmap.MAP_32BIT`, | ||
| :data:`mmap.MAP_TRANSLATED_ALLOW_EXECUTE`, :data:`mmap.MAP_UNIX03` and | ||
| :data:`mmap.MAP_TPRO`. All of them are ``mmap(2)`` flags on macOS. |
Member
There was a problem hiding this comment.
Suggested change
| Added :data:`mmap.MAP_NORESERVE`, :data:`mmap.MAP_NOEXTEND`, | |
| :data:`mmap.MAP_HASSEMAPHORE`, :data:`mmap.MAP_NOCACHE`, | |
| :data:`mmap.MAP_JIT`, :data:`mmap.MAP_RESILIENT_CODESIGN`, | |
| :data:`mmap.MAP_RESILIENT_MEDIA`, :data:`mmap.MAP_32BIT`, | |
| :data:`mmap.MAP_TRANSLATED_ALLOW_EXECUTE`, :data:`mmap.MAP_UNIX03` and | |
| :data:`mmap.MAP_TPRO`. All of them are ``mmap(2)`` flags on macOS. | |
| Added :data:`~mmap.MAP_32BIT`, :data:`~mmap.MAP_HASSEMAPHORE`, | |
| :data:`~mmap.MAP_JIT`, :data:`~mmap.MAP_NOCACHE`, :data:`~mmap.MAP_NOEXTEND`, | |
| :data:`~mmap.MAP_NORESERVE`, :data:`~mmap.MAP_RESILIENT_CODESIGN`, | |
| :data:`~mmap.MAP_RESILIENT_MEDIA`, :data:`~mmap.MAP_TPRO`, | |
| :data:`~mmap.MAP_TRANSLATED_ALLOW_EXECUTE`, and :data:`~mmap.MAP_UNIX03` | |
| constants in the :mod:`mmap` module. | |
| All of them are ``mmap(2)`` flags on macOS. |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
python#113869) The new flags were extracted from the macOS 14.2 SDK. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
python#113869) The new flags were extracted from the macOS 14.2 SDK. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
python#113869) The new flags were extracted from the macOS 14.2 SDK. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAP_constants defined on macOS but not inmmap#113868📚 Documentation preview 📚: https://cpython-previews--113869.org.readthedocs.build/