gh-113848: Use PyErr_GivenExceptionMatches() for check for CancelledError#113849
Merged
serhiy-storchaka merged 1 commit intoJan 9, 2024
Merged
Conversation
serhiy-storchaka
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
January 9, 2024 10:16
gvanrossum
approved these changes
Jan 9, 2024
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Looks like a nice improvement (though it hinges on this being an infallible legacy API).
Technically it's not 100% correct, since this C API doesn't appear to honor overriding __instancecheck__, but we use this function and PyErr_ExceptionMatches already in other places in this module, and I really don't think people should play games with subclassing CancelledError anyways.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.