gh-113791: Expose CLOCK_MONOTONIC_RAW_APPROX and CLOCK_UPTIME_RAW_APROX on macOS in the time module#113792
Merged
Merged
Conversation
…AW_APPROX on macOS in the time module
Contributor
Author
|
There are no test updates because existing CLOCK_* constants aren't tested either (other than indirectly testing some of them through tests of functions in the module) |
corona10
reviewed
Jan 7, 2024
corona10
left a comment
corona10
left a comment
Member
There was a problem hiding this comment.
LGTM, But let's follow convention of other constants :)
Member
Ah, some of the other constants have empty space. Can we unify them through this PR? |
erlend-aasland
approved these changes
Jan 7, 2024
Contributor
Author
That's why my entries have empty lines, I copied the last entry in the list :-) . I'll remove the blank lines. |
erlend-aasland
approved these changes
Jan 7, 2024
corona10
approved these changes
Jan 7, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…AW_APROX on macOS in the time module (python#113792)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…AW_APROX on macOS in the time module (python#113792)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…AW_APROX on macOS in the time module (python#113792)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--113792.org.readthedocs.build/