Skip to content

gh-113703: Correctly identify incomplete f-strings in the codeop module#113709

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-113703
Jan 5, 2024
Merged

gh-113703: Correctly identify incomplete f-strings in the codeop module#113709
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-113703

Conversation

@pablogsal

@pablogsal pablogsal commented Jan 4, 2024

Copy link
Copy Markdown
Member

Comment thread Misc/NEWS.d/next/Core and Builtins/2024-01-04-17-15-30.gh-issue-113703.Zsk0pY.rst Outdated

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor change in the news blurb. LGTM otherwise!

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal
pablogsal merged commit 3003fbb into python:main Jan 5, 2024
@pablogsal
pablogsal deleted the gh-113703 branch January 5, 2024 12:16
@miss-islington-app

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3003fbbf00422bce6e327646063e97470afa9091 3.12

@bedevere-app

bedevere-app Bot commented Jan 5, 2024

Copy link
Copy Markdown

GH-113733 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 5, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jan 5, 2024
…e codeop module (pythonGH-113709)

(cherry picked from commit 3003fbb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jan 5, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants