🤖 New build scheduled with the buildbot fleet by @vsajip for commit e923a3b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 0cb39ea 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Looks good!
(should we set required_on to at least one platform as typo protection?)

Thanks. Do you think that's needed for this specific issue? It seems a simple enough change. Not sure what you mean by typo protection. 

Not sure what you mean by typo protection.

I think @hauntsaninja is suggesting we require this pass on some platform to avoid a typo in the name of the module being imported since there's no error checking the module name is legitimate (although could that check be added thanks to sys.stdlib_module_names?).

@vsajip I added the backport label as I think this needs to land in 3.12 as well.

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

GH-113844 is a backport of this pull request to the 3.12 branch.

Yup, that's what I meant :-) Looks like sys.stdlib_module_names won't do the trick, it doesn't include things like _xxsubinterpreters or _wmi (and works less well for e.g. concurrent.futures)

Perhaps import_helper.import_module could be enhanced to do these checks? Wouldn't that be the best place for such?

Yeah, I took Brett's suggestion to mean we add a check against sys.stdlib_module_names in import_helper.import_module. Doing that naively doesn't work for the reasons I mention above, and not sure this is important enough to make an allowlist for it or whatever.