gh-113626: Add allow_code parameter in marshal functions#113648
Merged
serhiy-storchaka merged 6 commits intoJan 16, 2024
Conversation
Passing allow_code=False prevents serialization and de-serialization of code objects which is incompatible between Python versions.
eendebakpt
reviewed
Jan 2, 2024
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
vstinner
reviewed
Jan 10, 2024
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
approved these changes
Jan 16, 2024
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The error message is better thanks to the new WFERR_CODE_NOT_ALLOWED error code.
Member
Author
|
Thank you for your review Victor! |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…nGH-113648) Passing allow_code=False prevents serialization and de-serialization of code objects which is incompatible between Python versions.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…nGH-113648) Passing allow_code=False prevents serialization and de-serialization of code objects which is incompatible between Python versions.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…nGH-113648) Passing allow_code=False prevents serialization and de-serialization of code objects which is incompatible between Python versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing allow_code=False prevents serialization and de-serialization of code objects which is incompatible between Python versions.
📚 Documentation preview 📚: https://cpython-previews--113648.org.readthedocs.build/