gh-113569: Display calls in Mock.assert_has_calls failure when empty#113573
Merged
serhiy-storchaka merged 5 commits intoJan 4, 2024
Merged
Conversation
Contributor
Author
|
News failed the lint, but now i'm thinking this probably doesn't even need news, should I just remove it? |
sobolevn
reviewed
Dec 30, 2023
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
This change needs a NEWS entry :)
cjw296
reviewed
Dec 30, 2023
cjw296
reviewed
Dec 30, 2023
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
What do you think about displaying " Actual: not called" like in assert_called_with()?
cjw296
reviewed
Jan 2, 2024
cjw296
approved these changes
Jan 2, 2024
Contributor
Author
|
Thank you everyone for the reviews so far by the way, it's appreciated :) |
Contributor
|
@wookie184 - this looks ready to merge now, is that correct? |
Member
|
Thank you for your contribution @wookie184. It is not only added a useful feature, but made the code tidier in general. |
Contributor
|
Any backports needed @serhiy-storchaka ? |
Member
|
This is a new feature, not a bug fix. |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113569