Skip to content

bpo-35591: IDLE Find Selection now works when selection not found #11339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 2 commits into from
Dec 28, 2018
Merged

bpo-35591: IDLE Find Selection now works when selection not found #11339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
184b6d5
Move binding of self.bell so it always exists for find_selection calls.
terryjreedy Dec 28, 2018
953ac16
blurb
terryjreedy Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/idlelib/searchbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def __init__(self, root, engine):
icon (of dialog): ditto, use unclear if cannot minimize dialog.
'''
self.root = root
self.bell = root.bell
self.engine = engine
self.top = None

Expand Down Expand Up @@ -80,7 +81,6 @@ def create_widgets(self):
top.wm_title(self.title)
top.wm_iconname(self.icon)
self.top = top
self.bell = top.bell

self.row = 0
self.top.grid_columnconfigure(0, pad=2, weight=0)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2018-12-28-01-19-20.bpo-35591.SFpDj2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Find Selection now works when selection not found.