gh-113258: Write frozen modules to the build tree on Windows#113303
Merged
Conversation
itamaro
changed the title
Contributor
Author
|
@zooba this seems to be working now (except for the seemingly unrelated pythoninfo failure) . please take a look. I can incorporate further feedback in a polish pass (adding NEWS and whatnot, assuming this is NEWS-worthy) |
zooba
reviewed
Dec 22, 2023
zooba
left a comment
zooba
left a comment
Member
There was a problem hiding this comment.
Looks good, and seems to not affect POSIX builds, which is good.
I think we should have a NEWS item, but put it in the Build section (not Windows) and just specify that it changed the Windows build.
Member
|
Thanks for all the work on this! |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…ythonGH-113303) This ensures the source directory is not modified at build time, and different builds (e.g. different versions or GIL vs no-GIL) do not have conflicts.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ythonGH-113303) This ensures the source directory is not modified at build time, and different builds (e.g. different versions or GIL vs no-GIL) do not have conflicts.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ythonGH-113303) This ensures the source directory is not modified at build time, and different builds (e.g. different versions or GIL vs no-GIL) do not have conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move generated frozen modules out of the source tree and into the build tree on Windows build