GH-113225: Speed up pathlib.Path.glob()#113226
Merged
Merged
Conversation
Use `os.DirEntry.path` as the string representation of child paths, unless the parent path is empty, in which case we use the entry `name`.
Contributor
Author
|
Up to 15% faster in some simple tests: $ ./python -m timeit -s "from pathlib import Path" "list(Path().glob('**/*', follow_symlinks=True))"
5 loops, best of 5: 78.8 msec per loop # before
5 loops, best of 5: 67.9 msec per loop # after
# --> 1.16x faster
$ ./python -m timeit -s "from pathlib import Path" "list(Path.cwd().glob('**/*', follow_symlinks=True))"
5 loops, best of 5: 79.6 msec per loop # before
5 loops, best of 5: 70.5 msec per loop # after
# --> 1.13x fasteredit: patch revised; test cases for |
Member
|
How does it work for |
Contributor
Author
Same result but much slower (!), as the $ ./python -m timeit -s "from pathlib import Path" "[p.name for p in Path.cwd().iterdir()]"
2000 loops, best of 5: 139 usec per loop # before
1000 loops, best of 5: 371 usec per loop # afterWill fix! Thanks. |
barneygale
changed the title
pathlib.Path.iterdir() and glob()pathlib.Path.glob()
Contributor
Author
|
I've undone the change to With |
Contributor
Author
|
I've merged the ABC-specific changes separately (#113556) so this PR should be pretty laser-focused now :D |
Contributor
Author
|
Patch further revised so that we continue to set $ ./python -m timeit -s "from pathlib import Path" "list(Path().glob('**/*', follow_symlinks=True))"
5 loops, best of 5: 84.3 msec per loop # before
5 loops, best of 5: 80.1 msec per loop # after
$ ./python -m timeit -s "from pathlib import Path" "list(Path.cwd().glob('**/*', follow_symlinks=True))"
5 loops, best of 5: 84.4 msec per loop # before
5 loops, best of 5: 82 msec per loop # after |
barneygale
enabled auto-merge (squash)
January 4, 2024 20:38
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
Use `os.DirEntry.path` as the string representation of child paths, unless the parent path is empty, in which case we use the entry `name`.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Use `os.DirEntry.path` as the string representation of child paths, unless the parent path is empty, in which case we use the entry `name`.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Use `os.DirEntry.path` as the string representation of child paths, unless the parent path is empty, in which case we use the entry `name`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
os.DirEntry.pathas the string representation of child paths.Corner case: when we
os.scandir('.'), thepathatttribute will resemble'./foo', which isn't normalized by pathlib standards. In this case we use the entryname, which looks like'foo'.pathlib.Path.iterdir()and friends by usingos.DirEntry.path#113225