Skip to content

gh-112925: Fix error in example of datetime.time.fromisoformat and add doctest marker #112931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Dec 23, 2023
Merged

gh-112925: Fix error in example of datetime.time.fromisoformat and add doctest marker #112931

serhiy-storchaka merged 2 commits into from
Dec 23, 2023

Conversation

@F-park
Copy link
Contributor

@F-park F-park commented Dec 10, 2023 •
edited by github-actions bot
Loading

@ghost
Copy link

ghost commented Dec 10, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 10, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 10, 2023
Closed
pganssle
pganssle approved these changes Dec 12, 2023
View reviewed changes
Doc/library/datetime.rst

Examples::

.. doctest::
Copy link
Member

@pganssle pganssle Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't realize that anything actually was running these tests.

@pganssle pganssle added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 12, 2023
@serhiy-storchaka serhiy-storchaka merged commit bdc8d66 into python:main Dec 23, 2023
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 23, 2023

Thanks @F-park for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 23, 2023

GH-113427 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2023
@F-park @miss-islington
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
0b48d4d 
…` and add doctest marker (pythonGH-112931)

(cherry picked from commit bdc8d66)

Co-authored-by: F-park <52167622+F-park@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 23, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 23, 2023

GH-113428 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2023
@F-park @miss-islington
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
1b15581 
…` and add doctest marker (pythonGH-112931)

(cherry picked from commit bdc8d66)

Co-authored-by: F-park <52167622+F-park@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 23, 2023
serhiy-storchaka pushed a commit that referenced this pull request Dec 23, 2023
@miss-islington @F-park
[3.12] gh-112925: Fix error in example of `datetime.time.fromisoforma…
fee2bc1 
…t` and add doctest marker (GH-112931) (GH-113427)

(cherry picked from commit bdc8d66)

Co-authored-by: F-park <52167622+F-park@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Dec 23, 2023
@miss-islington @F-park
[3.11] gh-112925: Fix error in example of `datetime.time.fromisoforma…
0bd134d 
…t` and add doctest marker (GH-112931) (GH-113428)

(cherry picked from commit bdc8d66)

Co-authored-by: F-park <52167622+F-park@users.noreply.github.com>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@F-park @ryan-duve
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
26cbc27 
…` and add doctest marker (pythonGH-112931)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@F-park @kulikjak
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
6e60c6f 
…` and add doctest marker (pythonGH-112931)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@F-park @aisk
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
755ea5c 
…` and add doctest marker (pythonGH-112931)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@F-park @Glyphack
pythongh-112925: Fix error in example of `datetime.time.fromisoformat…
fc84a79 
…` and add doctest marker (pythonGH-112931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

+1 more reviewer

@thesayfulla thesayfulla thesayfulla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@F-park @pganssle @serhiy-storchaka @thesayfulla