-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-107784 Document interpid C-API and new Unstable API for fetching __main__ of interpreter
#112548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can be back-ported to Python 3.12 |
|
@ericsnowcurrently |
blaisep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change
A interpreter ID identifies a interpreter and may be used as an int.
to
A interpreter ID identifies a interpreter and may be used as an :class:`int`.
| :c:func:`Py_FinalizeEx` will destroy all sub-interpreters that | ||
| haven't been explicitly destroyed at that point. | ||
| Interpreter ID Objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm giving this some attention so that we can get it merged soon.
This section looks good so far
| Interpreter ID Objects | ||
| ---------------------- | ||
| A interpreter ID identifies a interpreter and may be used as an int. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk suggested that you link to the class definition,
changing
A interpreter ID identifies a interpreter and may be used as an int.
to
A interpreter ID identifies a interpreter and may be used as an :class:`int`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| A interpreter ID identifies a interpreter and may be used as an int. | |
| A interpreter ID identifies a interpreter and may be used as an :class:`int`. |
blaisep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(added the change as a markdown suggestion to make it more convenient)
| Interpreter ID Objects | ||
| ---------------------- | ||
| A interpreter ID identifies a interpreter and may be used as an int. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| A interpreter ID identifies a interpreter and may be used as an int. | |
| A interpreter ID identifies a interpreter and may be used as an :class:`int`. |
|
FYI, I've dropped interpreter ID objects. |
|
|
I'd need to double-check, but, yeah, we'd probably close this PR. |
Thank you @ericsnowcurrently , I will ask @tonybaloney if he will close this PR. |
|
@tonybaloney I'm going to close this PR. If needed we can reopen. Thanks. |
📚 Documentation preview 📚: https://cpython-previews--112548.org.readthedocs.build/