gh-111965: Use critical sections to make io.TextIOWrapper thread safe#112193
Merged
corona10 merged 7 commits intopython:mainfrom Nov 18, 2023
Merged
gh-111965: Use critical sections to make io.TextIOWrapper thread safe#112193corona10 merged 7 commits intopython:mainfrom
corona10 merged 7 commits intopython:mainfrom
Conversation
aisk
changed the title
corona10
reviewed
Nov 17, 2023
| @@ -0,0 +1 @@ | |||
| Using critical section to make ``io.TextIOWrapper`` thread safe without GIL. | |||
Member
There was a problem hiding this comment.
As I commented before, NEWS.d is not needed for this task
Contributor
Author
There was a problem hiding this comment.
Sorry, just noticed it
colesbury
changed the title
corona10
requested changes
Nov 18, 2023
Modules/_io/textio.c
Outdated
| #include "Python.h" | ||
| #include "pycore_call.h" // _PyObject_CallMethod() | ||
| #include "pycore_codecs.h" // _PyCodecInfo_GetIncrementalDecoder() | ||
| #include "pycore_critical_section.h" |
Member
There was a problem hiding this comment.
Please add a comment as the same as the other header. // Py_BEGIN_CRITICAL_SECTION()
corona10
reviewed
Nov 18, 2023
Co-authored-by: Donghee Na <donghee.na@python.org>
Contributor
Author
|
Thanks for the review! |
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disable-gilbuilds) #111965